Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement "streaming" multipart requests to multipart endpoint #1055

Merged
merged 8 commits into from
Oct 1, 2024
Merged

Implement "streaming" multipart requests to multipart endpoint #1055

merged 8 commits into from
Oct 1, 2024

Conversation

nfcampos
Copy link
Contributor

@nfcampos nfcampos commented Oct 1, 2024

  • Use streaming multipart encoder form requests_toolbelt
  • Currently dump each part to json before sending the request as that's the only way to enforce the payload size limit
  • When we lift payload size limit we should implement true streaming encoding, where each part is only encoded immediately before being sent over the connection, and use transfer-encoding: chunked

@nfcampos
Implement "streaming" multipart requests to multipart endpoint
f345d2c 
- Use streaming multipart encoder form requests_toolbelt
- Currently dump each part to json before sending the request as that's the only way to enforce the payload size limit
- When we lift payload size limit we should implement true streaming encoding, where each part is only encoded immediately before being sent over the connection, and use transfer-encoding: chunked
@nfcampos nfcampos force-pushed the nc/1oct/py-multipart branch from 036e19a to f345d2c Compare October 1, 2024 20:40
@nfcampos nfcampos merged commit 1f1b76a into nc/1oct/py-prepare-multipart Oct 1, 2024
5 of 6 checks passed
@nfcampos nfcampos deleted the nc/1oct/py-multipart branch October 1, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nfcampos