Skip to content

Commit

Permalink
Change the 'text' model type to 'llm' to match other libraries (#1019)
Browse files Browse the repository at this point in the history
  • Loading branch information
efriis authored Sep 19, 2024
1 parent 5c43494 commit e8ce685
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion js/src/schemas.ts
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ export type RetrieverOutput = Array<{
export interface InvocationParamsSchema {
ls_provider?: string;
ls_model_name?: string;
ls_model_type: "chat" | "text";
ls_model_type: "chat" | "llm";
ls_temperature?: number;
ls_max_tokens?: number;
ls_stop?: string[];
Expand Down
2 changes: 1 addition & 1 deletion js/src/wrappers/openai.ts
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ export const wrapOpenAI = <T extends OpenAIType>(

return {
ls_provider: "openai",
ls_model_type: "text",
ls_model_type: "llm",
ls_model_name: params.model,
ls_max_tokens: params.max_tokens ?? undefined,
ls_temperature: params.temperature ?? undefined,
Expand Down
2 changes: 1 addition & 1 deletion python/langsmith/wrappers/_openai.py
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,6 @@ def wrap_openai(
completions_name,
_reduce_completions,
tracing_extra=tracing_extra,
invocation_params_fn=functools.partial(_infer_invocation_params, "text"),
invocation_params_fn=functools.partial(_infer_invocation_params, "llm"),
)
return client

0 comments on commit e8ce685

Please sign in to comment.