-
Notifications
You must be signed in to change notification settings - Fork 85
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(js): Removes langchain and @langchain/core from peer deps to fix …
…npm installation (#1005) npm seems to have changed the way they handle circular deps - folks installing even old versions of `@langchain/core` that rely on a LangSmith version with the circular peer dep with npm are now getting: ``` Jacob:foo jacoblee$ npm i @langchain/[email protected] npm ERR! Cannot read properties of null (reading 'edgesOut') ``` This works: ``` { "name": "foo", "version": "1.0.0", "main": "index.js", "scripts": { "test": "echo \"Error: no test specified\" && exit 1" }, "author": "", "license": "ISC", "description": "", "dependencies": { "@langchain/core": "^0.1.29" }, "overrides": { "langsmith": "0.1.18" } } ``` This doesn't: ``` { "name": "foo", "version": "1.0.0", "main": "index.js", "scripts": { "test": "echo \"Error: no test specified\" && exit 1" }, "author": "", "license": "ISC", "description": "", "dependencies": { "@langchain/core": "^0.1.29" }, "overrides": { "langsmith": "0.1.55" } } ``` @dqbd I think this will break bundlers so we shouldn't merge but maybe we can otherwise mark as external? Otherwise we will have to split out all non-LangChain related code into e.g. `@langchain/langsmith-core`, have `@langchain/core` depend on that, and have `langsmith` re-export all of `@langchain/langsmith-core` with extra entrypoints, which is not ideal.
- Loading branch information
1 parent
5ed1a6f
commit e32c3c1
Showing
10 changed files
with
195 additions
and
143 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"name": "langsmith", | ||
"version": "0.1.55", | ||
"version": "0.1.56", | ||
"description": "Client library to connect to the LangSmith LLM Tracing and Evaluation Platform.", | ||
"packageManager": "[email protected]", | ||
"files": [ | ||
|
@@ -109,9 +109,9 @@ | |
"@babel/preset-env": "^7.22.4", | ||
"@faker-js/faker": "^8.4.1", | ||
"@jest/globals": "^29.5.0", | ||
"@langchain/core": "^0.2.17", | ||
"@langchain/langgraph": "^0.0.29", | ||
"@langchain/openai": "^0.2.5", | ||
"@langchain/core": "^0.3.1", | ||
"@langchain/langgraph": "^0.2.3", | ||
"@langchain/openai": "^0.3.0", | ||
"@tsconfig/recommended": "^1.0.2", | ||
"@types/jest": "^29.5.1", | ||
"@typescript-eslint/eslint-plugin": "^5.59.8", | ||
|
@@ -126,7 +126,7 @@ | |
"eslint-plugin-no-instanceof": "^1.0.1", | ||
"eslint-plugin-prettier": "^4.2.1", | ||
"jest": "^29.5.0", | ||
"langchain": "^0.2.10", | ||
"langchain": "^0.3.2", | ||
"openai": "^4.38.5", | ||
"prettier": "^2.8.8", | ||
"ts-jest": "^29.1.0", | ||
|
@@ -135,19 +135,11 @@ | |
"zod": "^3.23.8" | ||
}, | ||
"peerDependencies": { | ||
"@langchain/core": "*", | ||
"langchain": "*", | ||
"openai": "*" | ||
}, | ||
"peerDependenciesMeta": { | ||
"openai": { | ||
"optional": true | ||
}, | ||
"langchain": { | ||
"optional": true | ||
}, | ||
"@langchain/core": { | ||
"optional": true | ||
} | ||
}, | ||
"lint-staged": { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.