Fix run info type (#284)

langchain-ai · Nov 6, 2023 · c373ffb · c373ffb
1 parent 8a8f13a
commit c373ffb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/python/langsmith/client.py b/python/langsmith/client.py
@@ -2036,9 +2036,15 @@ def create_feedback(
             feedback_source.metadata["__run"] = {"run_id": str(source_run_id)}
         if feedback_source.metadata and "__run" in feedback_source.metadata:
             # Validate that the linked run ID is a valid UUID
-            feedback_source.metadata["__run"]["run_id"] = str(
-                _as_uuid(feedback_source.metadata["__run"]["run_id"])
-            )
+            # Run info may be a base model or dict.
+            _run_meta: Union[dict, Any] = feedback_source.metadata["__run"]
+            if hasattr(_run_meta, "dict") and callable(_run_meta):
+                _run_meta = _run_meta.dict()
+            if "run_id" in _run_meta:
+                _run_meta["run_id"] = str(
+                    _as_uuid(feedback_source.metadata["__run"]["run_id"])
+                )
+            feedback_source.metadata["__run"] = _run_meta
         feedback = ls_schemas.FeedbackCreate(
             id=feedback_id or uuid.uuid4(),
             run_id=run_id,

diff --git a/python/pyproject.toml b/python/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "langsmith"
-version = "0.0.57"
+version = "0.0.58"
 description = "Client library to connect to the LangSmith LLM Tracing and Evaluation Platform."
 authors = ["LangChain <[email protected]>"]
 license = "MIT"