Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: William FH <[email protected]>
  • Loading branch information
nfcampos and hinthornw authored Oct 2, 2024
1 parent 2ceeebf commit 89510e7
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions python/langsmith/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -1255,7 +1255,8 @@ def _run_transform(
logger.warning(
"You're trying to submit a run with attachments, but your current"
" LangSmith integration doesn't support it. Please contact the "
" LangChain team for assitance on how to upgrade."
" LangChain team at support at langchain"
" dot dev for assistance on how to upgrade."
)

return run_create
Expand Down Expand Up @@ -1597,15 +1598,17 @@ def multipart_ingest_runs(
for run in create_dicts:
if not run.get("trace_id") or not run.get("dotted_order"):
raise ls_utils.LangSmithUserError(
"Batch ingest requires trace_id and dotted_order to be set."
"Multipart ingest requires trace_id and dotted_order"
" to be set in create dicts."
)
else:
del run
if update_dicts:
for run in update_dicts:
if not run.get("trace_id") or not run.get("dotted_order"):
raise ls_utils.LangSmithUserError(
"Batch ingest requires trace_id and dotted_order to be set."
"Multipart ingest requires trace_id and dotted_order"
" to be set in update dicts."
)
else:
del run
Expand Down

0 comments on commit 89510e7

Please sign in to comment.