WIP: Serve playground from correct route if nested APIrouters within one another #580
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the username @StreetLamb on file. In order for us to review and merge your code, please complete the Individual Contributor License Agreement here https://forms.gle/AQFbtkWRoHXUgipM6 . This process is done manually on our side, so after signing the form one of the maintainers will add you to the contributors list. For more details about why we have a CLA and other contribution guidelines please see: https://github.com/langchain-ai/langserve/blob/main/CONTRIBUTING.md. |
eyurtsev
changed the title
|
@StreetLamb there are some other changes required to make this work, so i can't merge this yet, you can try installing off of this PR if that's helpful |
| # Fetching the playground URL using information in the route | ||
| # to support a case when the APIRouter is nested inside another | ||
| # APIRouter. | ||
| # In this case the prefix attribute of the APIRouter is not enough | ||
| # to get the correct playground URL. | ||
| route = request.scope["route"] | ||
| suffix = "/{file_path:path}" | ||
| route_path = route.path | ||
| full_suffix = "/playground" + suffix |
There was a problem hiding this comment.
This also seems like it can fix this issue. I've deployed the langserve application on AWS Lambda and set up an API Gateway to access the Lambda function. So, the URL access looks like this: https://api-id.execute-api.region.amazonaws.com/stage/model. Notice that there's a stage prefix in the URL before the path configured by langserve. Consequently, the langserve application isn't aware of the prefix. It will work correctly if I access the model using the invoke method, but it won't work if I access the playground. It will throw a network error because it tries to access assets from a path without the stage prefix.
There was a problem hiding this comment.
@eyurtsev Hi there! I couldn't find the reason why the CI failed. Could you please provide some information on that? I'm happy to assist with merging this PR. I tested with Python 3.10 locally. All the tests passed.
There was a problem hiding this comment.
There's some odd interaction between pytest and asyncio that's causing unit tests to hang occassionally. I haven't had time to address it yet.
There was a problem hiding this comment.
(it's not related to your PR!)
Update playground tests to check for the correct playground assets path in index.html. #578