Pass input value to handleChainStart in _transformStreamWithConfig
#7419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
size:XS
jacoblee93
reviewed
Dec 24, 2024
There was a problem hiding this comment.
I think there was a reason we don't do this but I can't remember what it was
You should be able to get the final input value from the handleChainEnd callback anyway right?
Can you add a test or two with permutations around what happens for transform inputs that aren't concattable?
| @@ -521,7 +521,7 @@ export abstract class Runnable< | |||
| async () => | |||
| callbackManager_?.handleChainStart( | |||
| this.toJSON(), | |||
| { input: "" }, | |||
| finalInput, | |||
There was a problem hiding this comment.
There are cases where finalInput is undefined right?
Should this fall back to the old value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a small change to the
Runnableclass in thelangchain-corepackage. The change passesfinalInputinstead of{ input: "" }to thehandleChainStartmethod. This allows the actual input value to be logged with tools like Langfuse.