Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community[minor]: Remove Dria retriever #7374

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erhant
Copy link
Contributor

@erhant erhant commented Dec 16, 2024

Dria has been previously added with #4302

While Dria is an active project, it is no longer doing retriever services, and shall be removed from LangChain as such.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 16, 2024
Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Dec 16, 2024 8:28am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Dec 16, 2024 8:28am

@dosubot dosubot bot added the auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs label Dec 16, 2024
@jacoblee93
Copy link
Collaborator

Thanks for cleaning up

Is the service completely gone now? Or would it be better to just remove from docs and add a warning?

@jacoblee93 jacoblee93 added the question Further information is requested label Dec 16, 2024
@erhant
Copy link
Contributor Author

erhant commented Dec 17, 2024

Hey!

Is the service completely gone now? Or would it be better to just remove from docs and add a warning?

It's gone right now, so I think we should remove it all-together.

We had a similar PR langchain Python as well (langchain-ai/langchain#28687) but I think the versioning is a bit strict due to Python, but here in JS we use optional dependencies etc. so if possible removal is better 🙏🏻

@efriis
Copy link
Member

efriis commented Dec 20, 2024

hey can we all chat on langchain-ai/langchain#28687 ?

it's unusual to ask to remove docs from langchain for a service that still documents the integration in their own docs, especially because this langchain integration is still documented in the dria docs https://dria.co/docs/integrations/langchain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs question Further information is requested size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants