fix(core): Make sure to return a callback manager if configure hooks #7366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ike to use This preserves existing behavior except for when library creators want handlers registered with the `registerConfigureHook` function. In that case, we want to make sure we return a callback manager.
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
the
auto:improvement
dosubot
bot
added
size:S
jacoblee93
changed the title
jacoblee93
reviewed
Dec 16, 2024
| @@ -1276,8 +1276,12 @@ export class CallbackManager | |||
| handler = new (handlerClass as any)({}); | |||
| } | |||
| if (handler !== undefined) { | |||
| if (!callbackManager?.handlers.some((h) => h.name === handler!.name)) { | |||
| callbackManager?.addHandler(handler, inheritable); | |||
| if (!callbackManager) { | |||
There was a problem hiding this comment.
Since this can potentially create a callback manager - let's move this whole block above where we add the inheritableTags and inheritableMetadata so that those are added properly
jacoblee93
changed the title
dosubot
bot
added
size:M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set a campaign manager, if we know there are callback managers we'd like to use
This preserves existing behavior except for when library creators want handlers registered with the
registerConfigureHookfunction. In that case, we want to make sure we return a callback manager.Twitter: @ibolmo