Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(community): allow metadata generics to flow through LibSQLVectorStore #7208

Merged
merged 1 commit into from
Nov 17, 2024
Merged

feat(community): allow metadata generics to flow through LibSQLVectorStore #7208

merged 1 commit into from
Nov 17, 2024

Conversation

cdierkens
Copy link
Contributor

  • adds generics to the LibSQLVectorStore

@vercel Vercel
Copy link

vercel bot commented Nov 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Nov 15, 2024 3:09am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Nov 15, 2024 3:09am

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels Nov 15, 2024
@cdierkens cdierkens mentioned this pull request Nov 15, 2024
Merged
@jacoblee93 jacoblee93 changed the title feat: allow metadata generics to flow through LibSQLVectorStore feat(community): allow metadata generics to flow through LibSQLVectorStore Nov 17, 2024
jacoblee93
jacoblee93 approved these changes Nov 17, 2024
View reviewed changes
Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Nov 17, 2024
@jacoblee93 jacoblee93 merged commit 074d1e1 into langchain-ai:main Nov 17, 2024
32 checks passed
FilipZmijewski pushed a commit to FilipZmijewski/langchainjs that referenced this pull request Nov 27, 2024
@cdierkens @FilipZmijewski
feat(community): allow metadata generics to flow through LibSQLVector…
d939328 
…Store (langchain-ai#7208)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacoblee93 jacoblee93 jacoblee93 approved these changes

Assignees
No one assigned
Labels
auto:improvement Medium size change to existing code to handle new use-cases lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdierkens @jacoblee93