fix[community]: Fixed missing tool_choice in call options of chat IBM #7192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
the
auto:bug
|
@jacoblee93 This is very simple fix if you could have a look at it, please. Did not manage to see the issue until updating package in langgraph based project. And receiving and error that types on |
jacoblee93
reviewed
Nov 12, 2024
| @@ -86,6 +87,7 @@ export interface WatsonxCallOptionsChat | |||
| extends Omit<BaseLanguageModelCallOptions, "stop">, | |||
There was a problem hiding this comment.
This should extend BaseChatModelCallOptions to prevent this in the future
|
Thanks! See comment but happy to merge and cut for now Are you sure this fixes it actually? |
|
yes, checked locally with langgraph, will fix accordingly to your comment in the next PR then. |
FilipZmijewski
added a commit
to FilipZmijewski/langchainjs
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed missing tool_choice in call options of chat model.
Was not aware of this issue until actually looking into langgraph implementation, maybe there could be an option to avoid such problems in the future?