Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(community): added code blocks in markdown into document's page content #7178

Conversation

FaresKi
Copy link
Contributor

@FaresKi FaresKi commented Nov 10, 2024

Hi!

Big fan of Langchain here :)
Was working with the Confluence Loader and I noticed that code snippets weren't added thru the Document's pageContent.
Let me know what you think!

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 10, 2024
Copy link

vercel bot commented Nov 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Nov 11, 2024 9:25pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Nov 11, 2024 9:25pm

@dosubot dosubot bot added the auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs label Nov 10, 2024
@jacoblee93
Copy link
Collaborator

Looks reasonable, thank you!

@jacoblee93 jacoblee93 changed the title feat: added code blocks in markdown into document's page content feat(community): added code blocks in markdown into document's page content Nov 11, 2024
@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Nov 11, 2024
@jacoblee93
Copy link
Collaborator

Please avoid updates after approval as CI needs to run again

@FaresKi
Copy link
Contributor Author

FaresKi commented Nov 11, 2024

My bad!

@jacoblee93 jacoblee93 merged commit 6db5fb8 into langchain-ai:main Nov 11, 2024
32 checks passed
@jacoblee93
Copy link
Collaborator

No worries, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants