Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community[patch]: fix: ElasticVectorSearch: exclude metadata filters … #6536

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

choeller
Copy link
Contributor

@choeller choeller commented Aug 15, 2024

…not working due to syntax error in filter creation

Fixes #6535

…not working due to syntax error in filter creation
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 15, 2024
Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Aug 16, 2024 8:55am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Aug 16, 2024 8:55am

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Aug 15, 2024
@jacoblee93
Copy link
Collaborator

Thanks for this - will add an integration test as well

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Aug 16, 2024
@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Aug 16, 2024
@jacoblee93 jacoblee93 merged commit 032c14b into langchain-ai:main Aug 16, 2024
34 checks passed
@choeller
Copy link
Contributor Author

Thank you for merging it that fast and adding the test! Great work you are doing!

CarterMorris pushed a commit to CarterMorris/langchainjs that referenced this pull request Nov 10, 2024
langchain-ai#6536)

* community[patch]: fix: ElasticVectorSearch: exclude metadata filters not working due to syntax error in filter creation

* Adds integration test

---------

Co-authored-by: Christoph Höller <[email protected]>
Co-authored-by: jacoblee93 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PRs that are ready to be merged as-is size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ElasticVectorSearch: exclude metadata filters not working due to syntax error in filter creation
2 participants