Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mistral[minor]: Start Mistral 1.0.0 migration #6514

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jacoblee93
Copy link
Collaborator

No description provided.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 13, 2024
Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 8:56am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Aug 13, 2024 8:56am

@jacoblee93 jacoblee93 changed the title Start Mistral 1.0.0 migration mistral[minor]: Start Mistral 1.0.0 migration Aug 13, 2024
@dosubot dosubot bot added the auto:improvement Medium size change to existing code to handle new use-cases label Aug 13, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Aug 13, 2024
@CarterMorris
Copy link
Contributor

Hello 👋, I am part of a group of University of Toronto students looking to help complete this migration. We see you've made some good progress already! From the build attempt, it looks like it failed to resolve some imports such as EmbeddngResponse, ChatCompletionResponse, ChatCompletionResponseChoice, ChatCompletionResponseChunk, and CompletionResponse. We would like to fix these and any more that may be broken! Are there any more you know of at the moment?

@jacoblee93
Copy link
Collaborator Author

Yes please feel free to take over!

@BaNg-W
Copy link
Contributor

BaNg-W commented Oct 21, 2024

Would you prefer if we contribute directly to the existing PR (#6514) or create our own separate branch and PR?

@jacoblee93
Copy link
Collaborator Author

Hey @BaNg-W, separate PR would be best - you can branch off this one though.

@desaxce
Copy link

desaxce commented Oct 23, 2024

@BaNg-W We should depend on the newer version 1.1.0. If you've started on a fork already let me know, otherwise I'll implement it tonight.

@BaNg-W
Copy link
Contributor

BaNg-W commented Oct 23, 2024

@desaxce Yeah I agree, we will be keeping up to date with 1.1.0 version. We’ve started to work on on the implementation but we were not in a rush to finish it immediately at the moment, are you in need of the updated mistral library version soon?

@desaxce
Copy link

desaxce commented Oct 23, 2024

@BaNg-W Not in a rush, early November would be good, I'd like to use Pixtral and that requires adapting messages in the chat completion API to be of type either string or array of {type: 'text', content: string} or {type: 'image_url', image_url: url}.

@BaNg-W
Copy link
Contributor

BaNg-W commented Oct 23, 2024

@desaxce Sure thing, early November seems like a very feasible timeline. And we’ll keep the chat completion API in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants