Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community[patch]: add clientParams option to Chroma vectorstore init args #6308

Merged
merged 4 commits into from
Aug 3, 2024
Merged

community[patch]: add clientParams option to Chroma vectorstore init args #6308

merged 4 commits into from
Aug 3, 2024

Conversation

jeasonnow
Copy link
Contributor

Fixes #6296

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 1, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 3, 2024 1:17am
langchainjs-docs ✅ Ready (Inspect) Visit Preview Aug 3, 2024 1:17am

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Aug 1, 2024
bracesproul
bracesproul previously requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, otherwise this looks good

libs/langchain-community/src/vectorstores/chroma.ts Outdated Show resolved Hide resolved
@bracesproul bracesproul changed the title [community]fix: #6296 add clientParams for chromadb. community[patch]: add clientParams option to Chroma vectorstore init args Aug 1, 2024
@jacoblee93
Copy link
Collaborator

Thanks for this!

@bracesproul before we ship a new community version with this can we make sure there's no peer dep conflicts from npm install?

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 2, 2024
@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label Aug 3, 2024
@jacoblee93
Copy link
Collaborator

Thank you!

@jacoblee93 jacoblee93 merged commit c8b2ffb into langchain-ai:main Aug 3, 2024
34 checks passed
This was referenced Aug 28, 2024
Closed
Open
@prathik2401 prathik2401 mentioned this pull request Aug 29, 2024
Merged
@riderx riderx mentioned this pull request Aug 29, 2024
Closed
@sindhuhack sindhuhack mentioned this pull request Aug 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bracesproul bracesproul bracesproul left review comments

Assignees
No one assigned
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Auth w/ Chroma
3 participants
@jeasonnow @jacoblee93 @bracesproul