all[minor]: Add ability to disable console logs in tests #6009

bracesproul · 2024-07-09T00:38:28Z

there's far too many console logs in our tests... this makes it difficult to diagnose failures in ci and similar. This PR allows for setting an env var (DISABLE_CONSOLE_LOGS) which will prevent console.log calls from actually logging anything.

vercel · 2024-07-09T00:38:35Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
langchainjs-api-refs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 9, 2024 0:47am
langchainjs-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 9, 2024 0:47am

dosubot · 2024-07-09T00:41:25Z

libs/create-langchain-integration/template/scripts/jest-setup-after-env.js

@@ -1,3 +1,9 @@
 import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";


Hey there! I noticed that the recent change in jest-setup-after-env.js adds a check for the DISABLE_CONSOLE_LOGS environment variable using process.env. I've flagged this for your review to ensure it aligns with our environment variable usage. Keep up the great work!

dosubot · 2024-07-09T00:41:26Z

libs/langchain-anthropic/scripts/jest-setup-after-env.js

@@ -1,3 +1,9 @@
 import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";


Hey there! 👋 I noticed that the recent change in jest-setup-after-env.js adds code to access an environment variable using process.env. I've flagged this for your review to ensure it aligns with our environment variable usage guidelines. Keep up the great work!

dosubot · 2024-07-09T00:41:27Z

libs/langchain-aws/scripts/jest-setup-after-env.js

@@ -1,3 +1,9 @@
 import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";


Hey there! I noticed that the recent change in jest-setup-after-env.js adds code to access an environment variable using process.env. This is flagged for your review. Let me know if you need further assistance with this.

dosubot · 2024-07-09T00:41:28Z

libs/langchain-azure-dynamic-sessions/scripts/jest-setup-after-env.js

@@ -1,3 +1,9 @@
 import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";


Hey there! I noticed that the recent change in jest-setup-after-env.js adds a check for the DISABLE_CONSOLE_LOGS environment variable. This is flagged for your review to ensure it aligns with our environment variable usage guidelines. Keep up the great work!

dosubot · 2024-07-09T00:41:29Z

libs/langchain-azure-openai/scripts/jest-setup-after-env.js

@@ -1,3 +1,9 @@
 import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";


Hey team, just wanted to flag the recent change in jest-setup-after-env.js that accesses the environment variable DISABLE_CONSOLE_LOGS using process.env. This is flagged for your review to ensure it aligns with our environment variable usage guidelines. Great work overall!

dosubot · 2024-07-09T00:41:30Z

libs/langchain-baidu-qianfan/scripts/jest-setup-after-env.js

@@ -1,3 +1,9 @@
 import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";


Hey there! I've reviewed the code and noticed that the recent change in jest-setup-after-env.js adds logic to access an environment variable using process.env. I've flagged this for your review to ensure it aligns with our environment variable usage guidelines. Let me know if you need further assistance with this.

dosubot · 2024-07-09T00:41:31Z

libs/langchain-cloudflare/scripts/jest-setup-after-env.js

@@ -1,3 +1,9 @@
 import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";


Hey there! I noticed that the recent change in jest-setup-after-env.js adds a check for the environment variable DISABLE_CONSOLE_LOGS using process.env. I've flagged this for your review to ensure it aligns with our environment variable usage. Keep up the great work!

dosubot · 2024-07-09T00:41:32Z

libs/langchain-cohere/scripts/jest-setup-after-env.js

@@ -1,3 +1,9 @@
 import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";


Hey there! I noticed that the recent code change in jest-setup-after-env.js is accessing and reading the value of the environment variable DISABLE_CONSOLE_LOGS. I've flagged this for your review to ensure it aligns with the project's standards. Keep up the great work!

dosubot · 2024-07-09T00:41:33Z

libs/langchain-community/scripts/jest-setup-after-env.js

@@ -1,3 +1,9 @@
 import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";


Hey there! I noticed that the recent change in jest-setup-after-env.js adds a check for the DISABLE_CONSOLE_LOGS environment variable using process.env. I've flagged this for your review to ensure it aligns with our environment variable usage guidelines. Keep up the great work!

dosubot · 2024-07-09T00:41:33Z

libs/langchain-exa/scripts/jest-setup-after-env.js

@@ -1,3 +1,9 @@
 import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";


Hey there! I noticed that the recent change in jest-setup-after-env.js adds code to access an environment variable using process.env. This comment is just to flag this change for the maintainers to review. Keep up the great work!

dosubot · 2024-07-09T00:41:34Z

libs/langchain-google-genai/scripts/jest-setup-after-env.js

@@ -1,3 +1,9 @@
 import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";


Hey there! I've reviewed the PR and noticed that the added code explicitly accesses an environment variable using process.env. I've flagged this for your review to ensure it aligns with our environment variable usage guidelines. Let me know if you need further assistance with this.

dosubot · 2024-07-09T00:41:35Z

libs/langchain-groq/scripts/jest-setup-after-env.js

@@ -1,3 +1,9 @@
 import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";


Hey there! I noticed that the recent change in jest-setup-after-env.js adds a check for the DISABLE_CONSOLE_LOGS environment variable. This comment is to flag the change for your review. Let me know if you need further assistance with this.

dosubot · 2024-07-09T00:41:36Z

libs/langchain-mistralai/scripts/jest-setup-after-env.js

@@ -1,3 +1,9 @@
 import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";


Hey there! I noticed that the recent change in jest-setup-after-env.js adds code to conditionally disable console.log based on the value of the environment variable DISABLE_CONSOLE_LOGS. I've flagged this for your review to ensure it aligns with our environment variable usage guidelines. Keep up the great work!

dosubot · 2024-07-09T00:41:37Z

libs/langchain-mixedbread-ai/scripts/jest-setup-after-env.js

@@ -1,3 +1,9 @@
 import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";


Hey there! I noticed that the recent change in jest-setup-after-env.js adds code to access an environment variable using process.env. I've flagged this for your review to ensure it aligns with our environment variable usage guidelines. Keep up the great work!

dosubot · 2024-07-09T00:41:38Z

libs/langchain-mongodb/scripts/jest-setup-after-env.js

@@ -1,3 +1,9 @@
 import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";


Hey there! I noticed that the recent change in jest-setup-after-env.js adds a check for the DISABLE_CONSOLE_LOGS environment variable using process.env. I've flagged this for your review to ensure it aligns with our environment variable usage. Keep up the great work!

dosubot · 2024-07-09T00:41:39Z

libs/langchain-nomic/scripts/jest-setup-after-env.js

@@ -1,3 +1,9 @@
 import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";


Hey there! I noticed that the recent PR includes a change that accesses an environment variable using process.env. This comment is just to flag this change for the maintainers to review. Keep up the great work!

dosubot · 2024-07-09T00:41:40Z

libs/langchain-pinecone/scripts/jest-setup-after-env.js

@@ -1,3 +1,9 @@
 import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";


Hey there! I noticed that the recent change in jest-setup-after-env.js adds a check for the environment variable DISABLE_CONSOLE_LOGS. I've flagged this for your review, just to ensure it aligns with our environment variable usage. Keep up the great work!

dosubot · 2024-07-09T00:41:41Z

libs/langchain-qdrant/scripts/jest-setup-after-env.js

@@ -1,3 +1,9 @@
 import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";


Hey there! 👋 I noticed that the recent change in jest-setup-after-env.js is flagging the access of the environment variable DISABLE_CONSOLE_LOGS for review. This is to ensure that the handling of environment variables aligns with best practices. Keep up the great work!

dosubot · 2024-07-09T00:41:41Z

libs/langchain-redis/scripts/jest-setup-after-env.js

@@ -1,3 +1,9 @@
 import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";


Hey team, I've reviewed the PR and noticed that the added code explicitly accesses an environment variable using process.env. This comment is to flag the change for maintainers to review the use of the environment variable. Great work overall!

dosubot · 2024-07-09T00:41:42Z

libs/langchain-standard-tests/scripts/jest-setup-after-env.js

@@ -1,3 +1,9 @@
 import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";


Hey there! I noticed that the recent change in jest-setup-after-env.js adds a check for the environment variable DISABLE_CONSOLE_LOGS using process.env. I've flagged this for your review to ensure it aligns with our environment variable usage. Keep up the great work!

dosubot · 2024-07-09T00:41:43Z

libs/langchain-textsplitters/scripts/jest-setup-after-env.js

@@ -1,3 +1,9 @@
 import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";


Hey there! I noticed that the recent change in jest-setup-after-env.js adds logic to access the environment variable DISABLE_CONSOLE_LOGS. This comment is to flag the change for maintainers to review the use of environment variables in the code. Great work!

dosubot · 2024-07-09T00:41:44Z

libs/langchain-weaviate/scripts/jest-setup-after-env.js

@@ -1,3 +1,9 @@
 import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";


Hey there! I noticed that the recent change in jest-setup-after-env.js adds a check for the environment variable DISABLE_CONSOLE_LOGS using process.env. I've flagged this for your review to ensure it aligns with our environment variable usage. Keep up the great work!

all[minor]: Add ability to disable console logs in tests

6502ebe

bracesproul marked this pull request as ready for review July 9, 2024 00:38

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels Jul 9, 2024

dosubot bot reviewed Jul 9, 2024

View reviewed changes

vercel bot deployed to Preview – langchainjs-api-refs July 9, 2024 00:47 View deployment

vercel bot deployed to Preview – langchainjs-docs July 9, 2024 00:47 View deployment

bracesproul merged commit 27d99e8 into main Jul 9, 2024
37 checks passed

bracesproul deleted the brace/disable-console-log-test-option branch July 9, 2024 00:50

This was referenced Jul 24, 2024

[Snyk] Upgrade @langchain/core from 0.2.8 to 0.2.12 prathik2401/sentilog-deploy#3

Merged

[Snyk] Upgrade langchain from 0.2.8 to 0.2.9 prathik2401/sentilog-deploy#10

Merged

abdulrahman305 mentioned this pull request Aug 1, 2024

[Snyk] Upgrade langchain from 0.0.96 to 0.2.9 abdulrahman305/langchain-chatbot-demo#11

Open

This was referenced Aug 2, 2024

[Snyk] Upgrade langchain from 0.0.156 to 0.2.9 askrella/whatsapp-chatgpt#354

Open

[Snyk] Upgrade langchain from 0.0.156 to 0.2.9 askrella/whatsapp-chatgpt#357

Open

filipeoliveiraa mentioned this pull request Aug 4, 2024

[Snyk] Upgrade langchain from 0.0.123 to 0.2.9 filipeoliveiraa/azurechatgpt#5

Open

prathik2401 mentioned this pull request Aug 6, 2024

[Snyk] Upgrade langchain from 0.2.9 to 0.2.10 prathik2401/sentilog-deploy#15

Merged

steve-hb mentioned this pull request Aug 6, 2024

[Snyk] Upgrade langchain from 0.0.156 to 0.2.10 askrella/whatsapp-chatgpt#358

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

all[minor]: Add ability to disable console logs in tests #6009

all[minor]: Add ability to disable console logs in tests #6009

bracesproul commented Jul 9, 2024 •

edited

Loading

vercel bot commented Jul 9, 2024 •

edited

Loading

dosubot bot Jul 9, 2024

dosubot bot Jul 9, 2024

dosubot bot Jul 9, 2024

dosubot bot Jul 9, 2024

dosubot bot Jul 9, 2024

dosubot bot Jul 9, 2024

dosubot bot Jul 9, 2024

dosubot bot Jul 9, 2024

dosubot bot Jul 9, 2024

dosubot bot Jul 9, 2024

dosubot bot Jul 9, 2024

dosubot bot Jul 9, 2024

dosubot bot Jul 9, 2024

dosubot bot Jul 9, 2024

dosubot bot Jul 9, 2024

dosubot bot Jul 9, 2024

dosubot bot Jul 9, 2024

dosubot bot Jul 9, 2024

dosubot bot Jul 9, 2024

dosubot bot Jul 9, 2024

dosubot bot Jul 9, 2024

dosubot bot Jul 9, 2024

		@@ -1,3 +1,9 @@
		import { awaitAllCallbacks } from "@langchain/core/callbacks/promises";

all[minor]: Add ability to disable console logs in tests #6009

all[minor]: Add ability to disable console logs in tests #6009

Conversation

bracesproul commented Jul 9, 2024 • edited Loading

vercel bot commented Jul 9, 2024 • edited Loading

dosubot bot Jul 9, 2024

Choose a reason for hiding this comment

dosubot bot Jul 9, 2024

Choose a reason for hiding this comment

dosubot bot Jul 9, 2024

Choose a reason for hiding this comment

dosubot bot Jul 9, 2024

Choose a reason for hiding this comment

dosubot bot Jul 9, 2024

Choose a reason for hiding this comment

dosubot bot Jul 9, 2024

Choose a reason for hiding this comment

dosubot bot Jul 9, 2024

Choose a reason for hiding this comment

dosubot bot Jul 9, 2024

Choose a reason for hiding this comment

dosubot bot Jul 9, 2024

Choose a reason for hiding this comment

dosubot bot Jul 9, 2024

Choose a reason for hiding this comment

dosubot bot Jul 9, 2024

Choose a reason for hiding this comment

dosubot bot Jul 9, 2024

Choose a reason for hiding this comment

dosubot bot Jul 9, 2024

Choose a reason for hiding this comment

dosubot bot Jul 9, 2024

Choose a reason for hiding this comment

dosubot bot Jul 9, 2024

Choose a reason for hiding this comment

dosubot bot Jul 9, 2024

Choose a reason for hiding this comment

dosubot bot Jul 9, 2024

Choose a reason for hiding this comment

dosubot bot Jul 9, 2024

Choose a reason for hiding this comment

dosubot bot Jul 9, 2024

Choose a reason for hiding this comment

dosubot bot Jul 9, 2024

Choose a reason for hiding this comment

dosubot bot Jul 9, 2024

Choose a reason for hiding this comment

dosubot bot Jul 9, 2024

Choose a reason for hiding this comment

bracesproul commented Jul 9, 2024 •

edited

Loading

vercel bot commented Jul 9, 2024 •

edited

Loading