core[minor],openai[patch],langchain[patch]: Allow tool functions to input ToolCall / return ToolMessage
#6005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
size:M
dosubot
bot
added
the
auto:improvement
2 tasks
eyurtsev
reviewed
Jul 9, 2024
langchain-core/src/callbacks/base.ts
Outdated
| @@ -197,7 +198,7 @@ abstract class BaseCallbackHandlerMethodsClass { | |||
| * Called at the end of a Tool run, with the tool output and the run ID. | |||
| */ | |||
| handleToolEnd?( | |||
| output: string, | |||
| output: string | ToolMessage, | |||
There was a problem hiding this comment.
I think this should be an any type -- a tool should be allowed to return anything, and we shouldn't be limiting the return type in anyway
Suggested change
| output: string | ToolMessage, | |
| output: any, |
There was a problem hiding this comment.
How would we handle things that aren't a string or tool message? Type check and e.g. JSON.stringify?
3 tasks
bracesproul
changed the title
ToolCall / return ToolMessage
…brace/tools-return-tool-message
jacoblee93
changed the title
ToolCall / return ToolMessageToolCall / return ToolMessage
dosubot
bot
added
size:L
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Followup PR will wrap all integrations with the
createToolCall/createToolCallChunkfuncTools can now:
ToolCallas an input.ToolMessageUpdated generics to reflect that.
Added a third generic to
toolfunc wrapper if you want to specify for the input arg of thefuncfield. (it will infer if no generics were prev passed)