langchain[patch]: Fix memory issue for large number of child chunks on large documents #5989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
auto:bug
jacoblee93
changed the title
jacoblee93
reviewed
Jul 9, 2024
| } | ||
| if (addToDocstore) { | ||
| await this.docstore.mset(Object.entries(fullDocs)); | ||
| await this._storeDocuments(parentDoc, taggedSubDocs, addToDocstore); |
There was a problem hiding this comment.
Flagging that this does make it a bit more likely that we'll get into half-finished states
jacoblee93
added a commit
that referenced
this pull request
Jul 9, 2024
* Fix memory issue for large number of chunks on large documents * Format --------- Co-authored-by: Clemens Peters <[email protected]>
|
Couldn't push to your branch so merged in #6012 after running |
This was referenced Jul 24, 2024
This was referenced Aug 2, 2024
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes OOM issues. The docker container of our index manager is killed on specific documents after using more than 2GB of memory. For large documents the ParentDocumentRetriever can create lots of parent and child documents.
While this change seems to fix the memory issues, I'm still investigating another issue on the same large document at the moment:
Uncaught exception: error: terminating connection due to idle-session timeout.@PetersClemens