Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bedrock[minor]: add support for metadata filtering #5973

Closed
wants to merge 1 commit into from
Closed

bedrock[minor]: add support for metadata filtering #5973

wants to merge 1 commit into from

Conversation

nick-elpedes
Copy link

Hey there! Bedrock supports filtering the documents that are searched for information by passing a RetrievalFilter object, and I wanted to be able to use this functionality with LangChain.

I added the necessary parameters to the queryKnowledgeBase function to allow for filters to be optionally passed when querying a Bedrock Knowledge Base.
This PR needs some more work, as I have been unable to build/test the repository when following the contributing guidelines.

This is my first PR on a public repository, so any help would be appreciated!

Fixes #5600

Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 2:52pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jul 3, 2024 2:52pm

@nick-elpedes nick-elpedes marked this pull request as ready for review July 3, 2024 15:25
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels Jul 3, 2024
@nick-elpedes nick-elpedes marked this pull request as draft July 3, 2024 15:41
@jl4nz
Copy link
Contributor

jl4nz commented Jul 24, 2024

@nick-elpedes Hi, FYI, I reworked this here #6189

@nick-elpedes
Copy link
Author

Alright, in that case, I'll close this. Thank you!

@nick-elpedes nick-elpedes deleted the feat/bedrock-meta-filtering branch July 24, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants