You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubotbot
added
auto:documentation
Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder
auto:improvement
Medium size change to existing code to handle new use-cases
labels
Jun 10, 2024
Hello, @jacoblee93! There was an automated comment regarding env variables access from examples and tests, in my mind this is fine, as it is just an example of a possible way of connecting to the database.
Also, should I change anything in the PR before it can be merged?
Thank you!
Hey @volodymyr-memsql - I'm getting src/indexes/vector_stores/singlestore_hybrid_search.ts(55,5): error TS2345: Argument of type '{ searchStrategy: "FILTER_BY_TEXT"; filterThershold: number; }' is not assignable to parameter of type 'SearchConfig' in one of the files in examples/ and it's causing CI to fail. Think you could have a look?
auto:documentationChanges to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folderauto:improvementMedium size change to existing code to handle new use-casessize:XLThis PR changes 500-999 lines, ignoring generated files.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dosubot
bot
added
the
size:XL
![dosubot[bot]](https://avatars.githubusercontent.com/in/324583?s=60&v=4){kind=small}
jacoblee93
changed the title
volodymyr-memsql
force-pushed
the
update_singlestore
branch
from
Update the
SingleStorevectorStoreclass with hybrid search functionality.This PR contains: