Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core[patch]: Support LANGSMITH_TRACING env var #5587

Merged
merged 4 commits into from
May 29, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion langchain-core/src/callbacks/manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -984,7 +984,8 @@ export class CallbackManager
getEnvironmentVariable("LANGCHAIN_VERBOSE") === "true" ||
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey team, just a heads up that I've flagged a change in the manager.ts file for review. The code now explicitly accesses and reads environment variables using the getEnvironmentVariable function, so it's worth double-checking to ensure everything is handled correctly.

options?.verbose;
const tracingV2Enabled =
getEnvironmentVariable("LANGCHAIN_TRACING_V2") === "true";
getEnvironmentVariable("LANGCHAIN_TRACING_V2") === "true" ||
getEnvironmentVariable("LANGSMITH_TRACING") === "true";

const tracingEnabled =
tracingV2Enabled ||
Expand Down
Loading