-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Amazon Bedrock integration, add chat model #2746
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -3,13 +3,22 @@ import { Bedrock } from "langchain/llms/bedrock"; | |||
// If no credentials are provided, the default credentials from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is flagging the change in the PR that requires the BEDROCK_AWS_ACCESS_KEY_ID
and BEDROCK_AWS_SECRET_ACCESS_KEY
environment variables to be set, and it should be reviewed by maintainers.
@@ -685,6 +686,8 @@ | |||
"@qdrant/js-client-rest": "^1.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on the PR! This comment is just to flag the addition of new dependencies (@smithy/protocol-http and @smithy/signature-v4) for maintainers to review, as it changes the project's peer/dev/hard dependencies.
@@ -0,0 +1,299 @@ | |||
import { SignatureV4 } from "@smithy/signature-v4"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds a new external HTTP request using fetch
. Please review this change to ensure it aligns with the project's requirements and security guidelines.
@@ -0,0 +1,299 @@ | |||
import { SignatureV4 } from "@smithy/signature-v4"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds a new import and usage of getEnvironmentVariable
to access an environment variable. Please review this change to ensure it is implemented correctly and securely.
@@ -0,0 +1,55 @@ | |||
/* eslint-disable no-process-env */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds code that explicitly accesses environment variables via process.env
. Please review this change to ensure that the environment variables are properly handled and secured.
@@ -1,386 +1,48 @@ | |||
/* eslint-disable no-process-env */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds, accesses, reads, or requires environment variables via process.env
or getEnvironmentVariable
. Please review this change to ensure proper handling and security of environment variables.
@@ -0,0 +1,430 @@ | |||
import { test, expect } from "@jest/globals"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds net-new, non-api client external HTTP requests using fetch. Please review this change to ensure it aligns with the project's requirements and best practices.
Supports streaming for Claude-v2, fixes #2744, fixes #2731, fixes #2645