Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: supabase vector store delete params ids typo #2745

Merged

Conversation

felipetodev
Copy link
Contributor

Fix typo in SupabaseVectorStore delete method

Currently, it only accepts an array of strings, but in our Supabase database, we can have a column of IDs as integers.

like your function example:

create table embeddings (
  id bigserial primary key,
  content text, -- corresponds to Document.pageContent
  metadata jsonb, -- corresponds to Document.metadata
  embedding vector(1536) -- 1536 works for OpenAI embeddings, change if needed
);

image

@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Sep 28, 2023 6:04pm

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Sep 28, 2023
@jacoblee93
Copy link
Collaborator

Thank you!

@jacoblee93 jacoblee93 self-assigned this Sep 28, 2023
@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label Sep 28, 2023
@jacoblee93 jacoblee93 merged commit 262e5d2 into langchain-ai:main Sep 28, 2023
@felipetodev felipetodev deleted the fix/vectorstores/delete-params-typo branch September 29, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PRs that are ready to be merged as-is
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants