Support to pull prompt templates and model configuration from MakerSuiteHub #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test data template and model.
Test same.
…low for connections to other Google APIs
…low for connections to other Google APIs
Implement forceLoad() Bug fixes in cache and logic.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
auto:enhancement
jacoblee93
reviewed
Oct 3, 2023
| return ret; | ||
| } | ||
|
|
||
| async load(id: string): Promise<MakerSuitePrompt> { |
There was a problem hiding this comment.
Strong preference between load vs. pull?
There was a problem hiding this comment.
Changing to pull() and forcePull()
jacoblee93
reviewed
Oct 3, 2023
| return ret; | ||
| } | ||
|
|
||
| toModel(): LLM | BaseChatModel { |
There was a problem hiding this comment.
This can just be BaseLanguageModel
|
So sorry about the delay - this seems reasonable, just missing entrypoints and docs |
jacoblee93
reviewed
Oct 3, 2023
| @@ -0,0 +1,358 @@ | |||
| import { protos } from "@google-ai/generativelanguage"; | |||
jacoblee93
reviewed
Oct 3, 2023
| @@ -0,0 +1,358 @@ | |||
| import { protos } from "@google-ai/generativelanguage"; | |||
| import { google } from "@google-ai/generativelanguage/build/protos/protos.js"; | |||
Chage some imports to import type.
|
@jacoblee93 - I think (hope) this is ready for final review and merge. |
|
Thank you, will look tomorrow! |
|
Should be good to go! Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2564
This creates a MakerSuiteHub class with methods to load (with cache) a text, "data", or chat prompt that has been saved via makersuite.google.com. This prompt has methods to convert to a template, a prompt-free model, or to a chain which combines the two.
There are also some changes in the base connection class and types to allow for more generic calls to other Google REST APIs (in this case, Google Drive).
Examples and other documentation are pending initial review to make sure this looks good, but the tests should be complete.