Merge remote-tracking branch 'origin/oracle-doc-table-loader' into or…

…acle-doc-loader
langchain-ai · Nov 24, 2024 · d9d8dd4 · d9d8dd4
2 parents 992838c + 43dc9a5
commit d9d8dd4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/libs/langchain-community/package.json b/libs/langchain-community/package.json
@@ -42,6 +42,7 @@
     "js-yaml": "^4.1.0",
     "langchain": ">=0.2.3 <0.3.0 || >=0.3.4 <0.4.0",
     "langsmith": "^0.2.0",
+    "oracledb": "^6.7.0",
     "uuid": "^10.0.0",
     "zod": "^3.22.3",
     "zod-to-json-schema": "^3.22.5"
@@ -118,6 +119,7 @@
     "@types/jsonwebtoken": "^9",
     "@types/lodash": "^4",
     "@types/mozilla-readability": "^0.2.1",
+    "@types/oracledb": "^6",
     "@types/pdf-parse": "^1.1.1",
     "@types/pg": "^8.11.0",
     "@types/pg-copy-streams": "^1.2.2",

diff --git a/libs/langchain-community/src/document_loaders/web/oracleai.ts b/libs/langchain-community/src/document_loaders/web/oracleai.ts
@@ -278,12 +278,6 @@ export class OracleDocLoader extends BaseDocumentLoader {
     return /^[A-Za-z_][A-Za-z0-9_]*$/.test(identifier);
   }
 
-  private async getUsername(): Promise<string> {
-    const result = await this.conn.execute<{ USER: string }>('SELECT USER FROM dual');
-    return (result.rows?.[0]?.USER) || "unknown_user";
-  }
-
-
   private async loadFromTable(m_params: any): Promise<Document[]> {
     const results: Document[] = [];
     try {

diff --git a/yarn.lock b/yarn.lock
@@ -11523,6 +11523,7 @@ __metadata:
     "@types/jsonwebtoken": ^9
     "@types/lodash": ^4
     "@types/mozilla-readability": ^0.2.1
+    "@types/oracledb": ^6
     "@types/pdf-parse": ^1.1.1
     "@types/pg": ^8.11.0
     "@types/pg-copy-streams": ^1.2.2
@@ -11601,6 +11602,7 @@ __metadata:
     node-llama-cpp: ^2
     notion-to-md: ^3.1.0
     officeparser: ^4.0.4
+    oracledb: ^6.7.0
     pdf-parse: 1.1.1
     pg: ^8.11.0
     pg-copy-streams: ^6.0.5