fix(community): chroma search without filter (#7183)

langchain-ai · Nov 12, 2024 · c5f336b · c5f336b
1 parent 5d526bc
commit c5f336b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/libs/langchain-community/src/vectorstores/chroma.ts b/libs/langchain-community/src/vectorstores/chroma.ts
@@ -354,6 +354,7 @@ export class Chroma extends VectorStore {
       throw new Error("cannot provide both `filter` and `this.filter`");
     }
     const _filter = filter ?? this.filter;
+    const where = _filter === undefined ? undefined : { ..._filter };
 
     const collection = await this.ensureCollection();
 
@@ -362,7 +363,7 @@ export class Chroma extends VectorStore {
     const result = await collection.query({
       queryEmbeddings: query,
       nResults: k,
-      where: { ..._filter },
+      where,
     });
 
     const { ids, distances, documents, metadatas } = result;

diff --git a/libs/langchain-community/src/vectorstores/tests/chroma.test.ts b/libs/langchain-community/src/vectorstores/tests/chroma.test.ts
@@ -128,7 +128,7 @@ describe("Chroma", () => {
     expect(mockCollection.query).toHaveBeenCalledWith({
       queryEmbeddings: query,
       nResults: expectedResultCount,
-      where: {},
+      where: undefined,
     });
     expect(results).toHaveLength(5);
   });