Clean up

langchain-ai · Jul 7, 2024 · 73a0698 · 73a0698
1 parent 69aa1b5
commit 73a0698
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 29 deletions.
diff --git a/langchain-core/src/runnables/base.ts b/langchain-core/src/runnables/base.ts
@@ -308,12 +308,6 @@ export abstract class Runnable<
     // to surface immediately.
     const config = ensureConfig(options);
     const callbackManager = await getCallbackManagerForConfig(config);
-    console.log(
-      "ABOUT TO STREAM",
-      config,
-      callbackManager?.getParentRunId(),
-      callbackManager?.handlers
-    );
     const wrappedGenerator = new AsyncGeneratorWithSetup({
       generator: this._streamIterator(input, config),
       config,

diff --git a/langchain-core/src/singletons/index.ts b/langchain-core/src/singletons/index.ts
@@ -1,5 +1,5 @@
 /* eslint-disable @typescript-eslint/no-explicit-any */
-import { type Client, RunTree } from "langsmith";
+import { RunTree } from "langsmith";
 import { isTracingEnabled } from "../utils/callbacks.js";
 
 export interface AsyncLocalStorageInterface {
@@ -49,21 +49,13 @@ class AsyncLocalStorageProvider {
         _lc_runnable_config: config,
       };
     } else {
-      let parentRun: RunTree | undefined;
-      let projectName: string | undefined;
-      let client: Client | undefined;
-
-      let tracingEnabled = isTracingEnabled();
-
-      console.log("PARENT RUN ID", parentRunId);
       const langChainTracer = handlers?.find(
-        (handler: any) => handler?.name == "langchain_tracer"
+        (handler: any) => handler?.name === "langchain_tracer"
       );
-
-      parentRun = langChainTracer?.getRun?.(parentRunId);
-      projectName = langChainTracer?.projectName;
-      client = langChainTracer?.client;
-      tracingEnabled = tracingEnabled || !!langChainTracer;
+      const tracingEnabled = isTracingEnabled() || !!langChainTracer;
+      const parentRun = langChainTracer?.getRun?.(parentRunId);
+      const projectName = langChainTracer?.projectName;
+      const client = langChainTracer?.client;
       newRunTree = new RunTree({
         client,
         tracingEnabled,
@@ -77,8 +69,6 @@ class AsyncLocalStorageProvider {
         },
       });
     }
-    // return storage.run({ extra: { _lc_runnable_config: config }}, callback);
-    // console.log("NEW RUN TREE", newRunTree);
     return storage.run(newRunTree, callback);
   }
 

diff --git a/langchain-core/src/singletons/tests/async_local_storage.test.ts b/langchain-core/src/singletons/tests/async_local_storage.test.ts
@@ -134,18 +134,17 @@ test("Config should be automatically populated after setting global async local
   ).toEqual(1);
 });
 
-test.only("Runnable streamEvents method with streaming nested in a RunnableLambda", async () => {
+test("Runnable streamEvents method with streaming nested in a RunnableLambda", async () => {
   AsyncLocalStorageProviderSingleton.initializeGlobalInstance(
     new AsyncLocalStorage()
   );
-  const asyncLocalStorage = AsyncLocalStorageProviderSingleton.getInstance();
   const chat = new FakeListChatModel({
     responses: ["Hello"],
   });
   const outerRunId = v4();
   const myFunc = async (input: string) => {
     const outerCallbackManager = await getCallbackManagerForConfig(
-      asyncLocalStorage.getStore()
+      AsyncLocalStorageProviderSingleton.getRunnableConfig()
     );
     expect(outerCallbackManager?.getParentRunId()).toEqual(outerRunId);
     for await (const _ of await chat.stream(input)) {
@@ -155,8 +154,6 @@ test.only("Runnable streamEvents method with streaming nested in a RunnableLambd
 
   const myNestedLambda = RunnableLambda.from(myFunc);
 
-  // console.log(await myNestedLambda.invoke("hello"));
-
   const events = [];
   for await (const event of myNestedLambda.streamEvents("hello", {
     version: "v1",

diff --git a/langchain-core/src/tracers/base.ts b/langchain-core/src/tracers/base.ts
@@ -91,7 +91,6 @@ export abstract class BaseTracer extends BaseCallbackHandler {
   }
 
   protected async _startTrace(run: Run) {
-    console.log("STARTING RUN", run, this.runMap);
     const currentDottedOrder = convertToDottedOrderFormat(
       run.start_time,
       run.id,

diff --git a/langchain-core/src/utils/stream.ts b/langchain-core/src/utils/stream.ts
@@ -206,7 +206,6 @@ export class AsyncGeneratorWithSetup<
     this.config = params.config;
     this.parentRunId = params.parentRunId;
     this.handlers = params.handlers;
-    console.log("IN SETUP", this.parentRunId, this.handlers);
     // setup is a promise that resolves only after the first iterator value
     // is available. this is useful when setup of several piped generators
     // needs to happen in logical order, ie. in the order in which input to