Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bge_huggingface.ipynb #8960

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Update bge_huggingface.ipynb #8960

merged 2 commits into from
Oct 17, 2023

Conversation

staoxiao
Copy link
Contributor

@staoxiao staoxiao commented Aug 9, 2023

  • Description: Considering the similarity computation method of BGE model is cosine similarity, set normalize_embeddings to be True.
  • Tag maintainer: @baskaryan

@vercel
Copy link

vercel bot commented Aug 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 9:39pm

@dosubot dosubot bot added Ɑ: embeddings Related to text embedding models module 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Aug 9, 2023
@baskaryan
Copy link
Collaborator

cc @manmax31

@leo-gan
Copy link
Collaborator

leo-gan commented Sep 20, 2023

@baskaryan Could you, please, review it?

@leo-gan leo-gan requested a review from baskaryan September 20, 2023 17:49
@leo-gan leo-gan added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Oct 16, 2023
@leo-gan leo-gan requested a review from efriis October 16, 2023 17:12
@baskaryan baskaryan merged commit 23c261b into langchain-ai:master Oct 17, 2023
3 checks passed
hoanq1811 pushed a commit to hoanq1811/langchain that referenced this pull request Feb 2, 2024
@staoxiao @efriis
Update bge_huggingface.ipynb (langchain-ai#8960)
d9c9e4e 
- Description: Considering the similarity computation method of
[BGE](https://github.com/FlagOpen/FlagEmbedding) model is cosine
similarity, set normalize_embeddings to be True.
- Tag maintainer: @baskaryan

Co-authored-by: Erick Friis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efriis efriis efriis approved these changes

@baskaryan baskaryan Awaiting requested review from baskaryan

Assignees
No one assigned
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder Ɑ: embeddings Related to text embedding models module lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@staoxiao @baskaryan @leo-gan @efriis