Community: LlamaCppEmbeddings embed_documents and embed_query
#28827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
the
size:S
dosubot
bot
added
community
|
@ccurme OKAY |
dosubot
bot
added
size:M
|
@ccurme please review |
ccurme
reviewed
Dec 20, 2024
| @@ -116,7 +117,14 @@ def embed_documents(self, texts: List[str]) -> List[List[float]]: | |||
| List of embeddings, one for each text. | |||
| """ | |||
| embeddings = self.client.create_embedding(texts) | |||
| return [list(map(float, e["embedding"])) for e in embeddings["data"]] | |||
| if not isinstance(embeddings["data"][0]["embedding"][0], list): | |||
There was a problem hiding this comment.
is it possible for this line to raise IndexError where it previously would not? e.g., if texts is empty or contains empty strings.
There was a problem hiding this comment.
Sorry for the confusion. I didn't mean to request that we raise an error where it previously would not.
From an ignorant reading of the code (i.e., no knowledge of the behavior of the client) the update introduced the potential to raise IndexError where it previously wouldn't. I've pushed a change that passes your tests. Let me know if you see any issues with it.
|
@ccurme please review |
ccurme
approved these changes
Dec 23, 2024
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
embed_documentsandembed_querywas throwing off the error as stated in the issue. The issue was thatLlamaclient is returning the embeddings in a nested list which is not being accounted for in the current implementation and therefore the stated error is being raised.