Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Multimodal Embeddings proposal #28710

Closed
wants to merge 11 commits into from
Closed

Conversation

fzowl
Copy link
Contributor

@fzowl fzowl commented Dec 13, 2024

Thank you for contributing to LangChain!

  • PR title: "package: description"
    • Where "package" is whichever of langchain, community, core, etc. is being modified. Use "docs: ..." for purely docs changes, "infra: ..." for CI changes.
    • Example: "community: add foobar LLM"

Description: this is a proposal on how to introduce multimodal embedding models to Langchain

Additional guidelines:

  • Make sure optional dependencies are imported within a function.
  • Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
  • Most PRs should not touch more than one package.
  • Changes should be backwards compatible.
  • If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 13, 2024
Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 11:38am

@dosubot dosubot bot added the Ɑ: embeddings Related to text embedding models module label Dec 13, 2024
@efriis efriis self-assigned this Dec 13, 2024
@efriis
Copy link
Member

efriis commented Dec 13, 2024

worth checking out #25356 as well!

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 13, 2024
@fzliu
Copy link
Contributor

fzliu commented Dec 17, 2024

I think perhaps we can figure out a way to make this a bit more universal -- applying not just to different types of modalities (audio, video, etc) but also to interleaved data or possibly even multiple parallel "tracks" of data (e.g. few video frames plus audio of those frames, embedded together).

@efriis From the Voyage perspective, we would love to support interleaved inputs (texts + images) to embedding models. Let us know what makes the most sense.

@ccurme
Copy link
Collaborator

ccurme commented Dec 19, 2024

Thanks very much for the thought put into this. Closing in favor of #25356. @fzowl @fzliu would you mind providing your feedback there?

@ccurme ccurme closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: embeddings Related to text embedding models module size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants