Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chroma[patch]: (nit) simplify test #28517

Merged
merged 1 commit into from
Dec 4, 2024
+2 −5
Merged

chroma[patch]: (nit) simplify test #28517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions libs/partners/chroma/tests/integration_tests/test_standard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from typing import AsyncGenerator, Generator

import pytest
from langchain_core.embeddings.fake import DeterministicFakeEmbedding
from langchain_core.vectorstores import VectorStore
from langchain_tests.integration_tests.vectorstores import (
AsyncReadWriteTestSuite,
Expand All @@ -15,8 +14,7 @@ class TestSync(ReadWriteTestSuite):
@pytest.fixture()
def vectorstore(self) -> Generator[VectorStore, None, None]: # type: ignore
"""Get an empty vectorstore for unit tests."""
embeddings = DeterministicFakeEmbedding(size=10)
store = Chroma(embedding_function=embeddings)
store = Chroma(embedding_function=self.get_embeddings())
try:
yield store
finally:
Expand All @@ -28,8 +26,7 @@ class TestAsync(AsyncReadWriteTestSuite):
@pytest.fixture()
async def vectorstore(self) -> AsyncGenerator[VectorStore, None]: # type: ignore
"""Get an empty vectorstore for unit tests."""
embeddings = DeterministicFakeEmbedding(size=10)
store = Chroma(embedding_function=embeddings)
store = Chroma(embedding_function=self.get_embeddings())
try:
yield store
finally:
Expand Down
Loading