[Community]: Image Extraction Fixed for PDFPlumberParser
#28491
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:XS
dosubot
bot
added
size:S
2 similar comments
There was a problem hiding this comment.
seems like @c-xlenz had some feedback worth addressing: #28480 (comment)
libs/community/pyproject.toml
Outdated
| @@ -41,6 +41,7 @@ dataclasses-json = ">= 0.5.7, < 0.7" | |||
| pydantic-settings = "^2.4.0" | |||
| langsmith = "^0.1.125" | |||
| httpx-sse = "^0.4.0" | |||
| pillow = "^11.0.0" | |||
There was a problem hiding this comment.
we shouldn't be adding any new required dependencies — is there any other way to fix
There was a problem hiding this comment.
@baskaryan The way I see it no.
There was a problem hiding this comment.
@baskaryan let me know what I can do then.
There was a problem hiding this comment.
For this fix, I need pillow otherwise it won't work.
There was a problem hiding this comment.
@keenborder786, optional dependencies can be OK, but not required ones
Also please get in the habit of including tests with PRs. We want to avoid a situation where a bug fix, is introducing new bug fixes (e.g., #28480 (comment))
There was a problem hiding this comment.
@eyurtsev okay.
There was a problem hiding this comment.
@eyurtsev @baskaryan I have removed pillow as a required dependency. Please check now.
| @@ -427,6 +427,13 @@ def __init__( | |||
| text_kwargs: Keyword arguments to pass to ``pdfplumber.Page.extract_text()`` | |||
| dedupe: Avoiding the error of duplicate characters if `dedupe=True`. | |||
| """ | |||
| try: | |||
| import PIL # noqa:F401 | |||
There was a problem hiding this comment.
I think this is OK (will not raise new errors for users) because Pillow is already a dependency of pdfplumber.
dosubot
bot
added
the
lgtm
PDFPlumberParser