docs: Correct thread_id consistency for conversation history example #28470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix the problem DOC: Managing Conversation History langchain-ai#28450 Problem in the Example: query1: "What is my name?" thread_id: abc567 query2: "What math problem did I ask?" thread_id: abc678 The change in thread_id is incorrect, as both queries should belong to the same conversation. Intended Behavior to Demonstrate: After trimming the chat history, the context for query1 is discarded. The model cannot answer it. The context for query2 is retained, so the model can still respond to it. What have I do: Change those two thread_id, now they are the same one. Check other thread_id in Toturials page.
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
🤖:docs
|
hey! just ran the existing code, and it's working as expected. if we use the same thread id, then it'll duplicate some of the messages, so the intention is actually to create a new thread (with the same conversation history in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to LangChain!
Description: Updated the documentation to ensure that both queries in the conversation history example share the same thread_id, reflecting a single conversation context. This change aligns with the intended behavior where the model should discard the context for query1 after trimming the chat history and retain the context for query2.
Issue: DOC: Managing Conversation History #28450
Dependencies: No additional dependencies required for this change.