-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
langchain: enable weaviate v4 and its usage as self-query retriever #28442
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
06a9385
to
b51af9d
Compare
…ts/vectorstores/test_weaviate.py
test_weaviate.py is working Don't keep the cassetts
Deployment failed with the following error:
|
hey there! Could you work with @hsm207 to put this where the weaviate team would like this (most likely in the https://github.com/langchain-ai/langchain-weaviate repo) Once it's in, feel free to reopen with just the docs file change! |
Got it. This PR unfortunately wasn't mergable in its current state for a variety of reasons. feel free to put up a pr more like https://github.com/langchain-ai/langchain/pull/28292/files In particular, please avoid adding any dependencies. You're welcome to skip the integration tests if @hsm207 confirms the implementation it's importing should work with the self query retriever here. |
I got your point. My takeaway:
|
certainty
is almost 1 but can be off by a tiny amount. I updated them.make format
,make lint
andmake test
from the root of both libs/langchain and libs/community. There were still several test errors from the parts of the code base that I didn't touch.