Community: Adding bulk_size as a setable param for OpenSearchVectorSearch #28325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:S
efriis
reviewed
Dec 9, 2024
| @@ -618,7 +615,6 @@ def add_embeddings( | |||
| text_embeddings: Iterable[Tuple[str, List[float]]], | |||
| metadatas: Optional[List[dict]] = None, | |||
| ids: Optional[List[str]] = None, | |||
| bulk_size: int = 500, | |||
There was a problem hiding this comment.
breaking change - can we keep this, and use the passed-in as an override? can still default to the self.bulk_size behavior if it's None
efriis
reviewed
Dec 9, 2024
| @@ -596,7 +594,6 @@ async def aadd_texts( | |||
| texts: Iterable[str], | |||
| metadatas: Optional[List[dict]] = None, | |||
| ids: Optional[List[str]] = None, | |||
| bulk_size: int = 500, | |||
| @@ -1085,7 +1081,6 @@ def from_texts( | |||
| texts: List[str], | |||
| embedding: Embeddings, | |||
| metadatas: Optional[List[dict]] = None, | |||
| bulk_size: int = 500, | |||
| @@ -1150,7 +1145,6 @@ async def afrom_texts( | |||
| texts: List[str], | |||
| embedding: Embeddings, | |||
| metadatas: Optional[List[dict]] = None, | |||
| bulk_size: int = 500, | |||
|
Hi @efriis , thanks for reviewing my request, really appreciate it. :) |
efriis
approved these changes
Dec 12, 2024
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When using langchain.retrievers.parent_document_retriever.py with vectorstore is OpenSearchVectorSearch, I found that the bulk_size param I passed into OpenSearchVectorSearch class did not work on my ParentDocumentRetriever.add_documents() function correctly, it will be overwrite with int 500 the function which OpenSearchVectorSearch class had (e.g., add_texts(), add_embeddings()...).
So I made this PR requset to fix this, thanks!