partners[chroma]: add retrieval of embedding vectors #28290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:M
mspronesti
changed the title
mspronesti
force-pushed
the
feat/chroma-vector
branch
from
56ffe0d to
06bbe03
Compare
ccurme
reviewed
Nov 27, 2024
| """Test end to end construction and scored search.""" | ||
| texts = ["foo", "bar", "baz"] | ||
| metadatas = [{"page": str(i)} for i in range(len(texts))] | ||
| embeddings = FakeEmbeddings() |
There was a problem hiding this comment.
Does this test pass? Do we need ConsistentFakeEmbeddings instead of FakeEmbeddings?
There was a problem hiding this comment.
It seems to be passing in my local env. Did it fail in yours?
There was a problem hiding this comment.
Took a look at this. The FakeEmbeddings in Chroma is returning a fixed vector for each query. So the test isn't very stringent. Updated it to use ConsistentFakeEmbeddings, which is different for each query.
ccurme
approved these changes
Nov 27, 2024
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional method to
Chromato retrieve the embedding vectors, besides the most relevant Documents. This is sometimes of use when you need to run a postprocessing algorithm on the retrieved results based on the vectors, which has been the case for me lately.Example issue (discussion) requesting this change: #20383