-
Notifications
You must be signed in to change notification settings - Fork 15.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Poetry version, to current latest (1.8.4) #28194
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
7b1c4b8
to
fc02f91
Compare
was this creating issues? in general we don't update these versions for each release, because in CI |
@efriis I wasn't going for a fix, this was more of a maintenance task. As far as I understood, CI config has been neglected for a while. It's expected to install those lock files with the version that locked them because the file format changes by the versions and using the latest comes with performance issues. I wouldn't push for updating the config with every patch release of the tools, but I think it's good to merge this PR for mainly two reasons:
|
Hey again, I came up with another pro argument for this exact version. https://github.com/python-poetry/poetry/releases/tag/1.8.4 Poetry validates Python 3.13 support with version 1.8.4, so any version older than that is not officially compatible with Python 3.13. Considering there are not many blockers for langchain's 3.13 support, 3.13 support at poetry level is a nice thing to have. |
sounds good! will probably wait to merge this until after thanksgiving because I'm ooo next week, and we've had some unexpected issues pop up in the past with other CI pipelines that get impacted by poetry upgrades |
fc02f91
to
8fce4ba
Compare
@efriis Thanks for the approval. I rebased the branch and solved the conflicts, it should be ready to merge now. |
sounds good thanks! |
Update all Poetry versions to the current latest, 1.8.4 .
I was checking how lock files are managed and found out that even though the files are generated - updated with the current latest version of Poetry, the version used in CI and Dockerfile was outdated.