Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Poetry version, to current latest (1.8.4) #28194

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

ulgens
Copy link
Contributor

@ulgens ulgens commented Nov 18, 2024

Update all Poetry versions to the current latest, 1.8.4 .

I was checking how lock files are managed and found out that even though the files are generated - updated with the current latest version of Poetry, the version used in CI and Dockerfile was outdated.

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 6:55pm

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Nov 18, 2024
@ulgens ulgens force-pushed the update_poetry_1.8.4 branch 2 times, most recently from 7b1c4b8 to fc02f91 Compare November 18, 2024 23:27
@ulgens ulgens changed the title all: Update Poetry version, to current latest (1.8.4) Update Poetry version, to current latest (1.8.4) Nov 19, 2024
@efriis
Copy link
Member

efriis commented Nov 19, 2024

was this creating issues? in general we don't update these versions for each release, because in CI poetry is just used for installing from lockfiles.

@ulgens
Copy link
Contributor Author

ulgens commented Nov 19, 2024

@efriis I wasn't going for a fix, this was more of a maintenance task. As far as I understood, CI config has been neglected for a while. It's expected to install those lock files with the version that locked them because the file format changes by the versions and using the latest comes with performance issues.

I wouldn't push for updating the config with every patch release of the tools, but I think it's good to merge this PR for mainly two reasons:

  • Having consistency across pipelines
  • The oldest version that currently being used was released almost 2 years ago and poetry released 14 versions after that

@ulgens
Copy link
Contributor Author

ulgens commented Nov 20, 2024

Hey again, I came up with another pro argument for this exact version.

https://github.com/python-poetry/poetry/releases/tag/1.8.4

Poetry validates Python 3.13 support with version 1.8.4, so any version older than that is not officially compatible with Python 3.13. Considering there are not many blockers for langchain's 3.13 support, 3.13 support at poetry level is a nice thing to have.

@efriis
Copy link
Member

efriis commented Nov 20, 2024

sounds good! will probably wait to merge this until after thanksgiving because I'm ooo next week, and we've had some unexpected issues pop up in the past with other CI pipelines that get impacted by poetry upgrades

@efriis efriis self-assigned this Nov 20, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Nov 20, 2024
@ulgens ulgens force-pushed the update_poetry_1.8.4 branch from fc02f91 to 8fce4ba Compare November 26, 2024 08:15
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 26, 2024
@ulgens
Copy link
Contributor Author

ulgens commented Nov 26, 2024

@efriis Thanks for the approval. I rebased the branch and solved the conflicts, it should be ready to merge now.

@efriis efriis enabled auto-merge (squash) December 2, 2024 18:55
@efriis efriis disabled auto-merge December 2, 2024 18:55
@efriis efriis enabled auto-merge (squash) December 2, 2024 18:55
@efriis
Copy link
Member

efriis commented Dec 2, 2024

sounds good thanks!

@efriis efriis merged commit c953f93 into langchain-ai:master Dec 2, 2024
83 checks passed
@ulgens ulgens deleted the update_poetry_1.8.4 branch December 2, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants