Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community: Using ro_qeury with FalkorDB doesn't allow destructive operations #28095

Closed
wants to merge 4 commits into from

Conversation

gkorland
Copy link
Contributor

ref #28050

Thank you for contributing to LangChain!

  • PR title: "package: description"

    • Where "package" is whichever of langchain, community, core, etc. is being modified. Use "docs: ..." for purely docs changes, "infra: ..." for CI changes.
    • Example: "community: add foobar LLM"
  • PR message: No need to force opt in with FalkorDB

    • Description: Using ro_qeury with FalkorDB doesn't allow destructive operations
    • Twitter handle: @g_korland
  • Lint and test: Run make format, make lint and make test from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/

@efriis

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 7:01pm

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 13, 2024
@dosubot dosubot bot added the community Related to langchain-community label Nov 13, 2024
@efriis
Copy link
Member

efriis commented Dec 5, 2024

this introduces a CVE by removing danger warnings about sql injection

@efriis efriis closed this Dec 5, 2024
@efriis
Copy link
Member

efriis commented Dec 5, 2024

here's the CVE: GHSA-45pg-36p6-83v9

the issue is not only destructive actions, but also data exfiltration

@efriis
Copy link
Member

efriis commented Dec 5, 2024

if you wanted to reopen this just switching to ro_query that could work, under some flag. But it would have to keep the security warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants