-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: integrations/providers/More
#28071
docs: integrations/providers/More
#28071
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@efriis Hey Erick, can you, please, check the Vercel error? I've added a page generation script to Makefile but it doesn't work and I cannot localize the problem, since I cannot reproduce the Vercel workflow locally. |
integrations/providers/More
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
completely understand sometimes scripts are the best way to do things, but scripts like this are quite difficult to maintain long-term.
In this particular case, I think it would be better to do this as a mdx component that iterates through the sidebar data to achieve the same end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I'll try to do it as an mdx component. Thanks for the feedback, Erick!
great thank you! Feel free to mark ready to review at that point |
b77a7d5
to
feb480e
Compare
7ae89d6
to
95a33b2
Compare
16ac594
to
86db8dc
Compare
got it. I actually prefer the current to the preview https://langchain-git-fork-leo-gan-docs-integrations-p-2e3492-langchain.vercel.app/docs/integrations/providers/all/ so i will close it. one way that could be interesting to resolve this is to see if there are any other docusaurus plugins/themes that handle the "page listing" component nicely |
The current
integration/providers/all
page is not readable. It has too many items.I've generated it with A-Z menu. Now it is much easier to navigate.
See the result page.