Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: KuzuGraph needs allow_dangerous_requests, add graph documents via LLMGraphTransformer #27949

Merged
merged 39 commits into from
Dec 10, 2024

Conversation

prrao87
Copy link
Contributor

@prrao87 prrao87 commented Nov 6, 2024

  • PR title: "community: Kuzu - Add graph documents via LLMGraphTransformer"

    • This PR adds a new method add_graph_documents to use the GraphDocuments extracted by LLMGraphTransformer and store in a Kùzu graph backend.
    • This allows users to transform unstructured text into a graph that uses Kùzu as the graph store.
  • Lint and test: Run make format, make lint and make test from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 3:15am

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 6, 2024
@prrao87 prrao87 changed the title Add graph documents via LLMGraphTransformer Add graph documents via LLMGraphTransformer to KuzuGraph Nov 6, 2024
@dosubot dosubot bot added the community Related to langchain-community label Nov 6, 2024
@prrao87 prrao87 changed the title Add graph documents via LLMGraphTransformer to KuzuGraph community: Kuzu - Add graph documents to Kùzu graph via LLMGraphTransformer Nov 7, 2024
@prrao87 prrao87 changed the title community: Kuzu - Add graph documents to Kùzu graph via LLMGraphTransformer community: Kùzu - Add graph documents to Kùzu graph via LLMGraphTransformer Nov 7, 2024
@prrao87
Copy link
Contributor Author

prrao87 commented Nov 15, 2024

Hi, could I please get an eta on when this could be merged?

cc @baskaryan @eyurtsev

@prrao87 prrao87 changed the title community: Kùzu - Add graph documents to Kùzu graph via LLMGraphTransformer [ommunity][kuzu] - Add graph documents to Kùzu graph via LLMGraphTransformer Nov 28, 2024
@prrao87 prrao87 changed the title [ommunity][kuzu] - Add graph documents to Kùzu graph via LLMGraphTransformer [community][kuzu] - Add graph documents to Kùzu graph via LLMGraphTransformer Nov 28, 2024
@prrao87
Copy link
Contributor Author

prrao87 commented Nov 28, 2024

Hi again, checking in on the status of this PR. Thanks!

cc @vbarda @ccurme

@prrao87
Copy link
Contributor Author

prrao87 commented Dec 4, 2024

Trying my luck with @hwchase17. I'd really appreciate it if this PR were reviewed and merged so that Kùzu users who are coming from LangChain can benefit. Cheers!

@alonsosilvaallende
Copy link
Contributor

When can this be merged? Looking forward to it!

@ChuckNoelke
Copy link

Hi, when can the merge happen? At my company, we have would like to test it as soon as possible!

@efriis efriis self-assigned this Dec 9, 2024
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey! given this is very susceptible to sql injection in the relationships objects, would you be open to adding a allow_dangerous_requests: bool flag that is required to be true to the top-level class? Can also add to the add_graph_documents function just for this PR if that makes more sense to you

@prrao87
Copy link
Contributor Author

prrao87 commented Dec 9, 2024

Hi @efriis thanks for the response. I think it makes sense to add to the add_graph_documents function as this is the one that actually creates the graph using these f-string queries (I didn't have a choice as the table names need to be constructed dynamically in Kùzu). Could you advise on where the flag can be applied exactly and update this PR? Thanks!

Copy link

vercel bot commented Dec 10, 2024

Deployment failed with the following error:

Redirect at index 24 has invalid `source` pattern "/docs/integrations/retrievers/weaviate-hybrid/?".

Learn More: https://vercel.link/invalid-route-source-pattern

@efriis
Copy link
Member

efriis commented Dec 10, 2024

ended up doing on the init - it looks like user-provided text can also be passed in query and others, so this can fix across!

@efriis efriis changed the title [community][kuzu] - Add graph documents to Kùzu graph via LLMGraphTransformer community: KuzuGraph needs allow_dangerous_requests, add graph documents via LLMGraphTransformer Dec 10, 2024
@efriis efriis enabled auto-merge (squash) December 10, 2024 03:08
@efriis efriis merged commit 8c6eec5 into langchain-ai:master Dec 10, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants