Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: Ontotext GraphDB Graph & QA Chain use SPARQLWrapper instead of rdflib #27874

Closed

Conversation

nelly-hateva
Copy link
Contributor

  • Description: Ontotext GraphDB & QA Chain use the SPARQLWrapper instead of rdflib:
    • the client can now use any authentication method supported by GraphDB, not just basic auth
    • some SPARQL queries are not valid, but the rdflib doesn't raise an exception and swallows the server error message, so instead of validating the queries on the client side with rdflib, we now validate them on the server and pass a good error message to the LLM
  • Issue: N/A
  • Dependencies: SPARQLWrapper
  • Twitter handle: @OntotextGraphDB

Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:50am

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. community Related to langchain-community labels Nov 4, 2024
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so unfortunately this change is a breaking change for existing users, so this would have to be done in a new integration, which is actually the best path forward for this integration! Added bonus because it seems you work on it :)

we'd love to get an integration package out! Future PRs against langchain would just be {docs updates, as well as registering your package in libs/packages.yml, deprecating this community integration in favor of your integration package}

Here's the guide, and if you have questions, feel free to leave them in the comments on those pages so others can see them! https://python.langchain.com/docs/contributing/how_to/integrations/

@efriis
Copy link
Member

efriis commented Dec 16, 2024

going to close with the above recommendation - as mentioned feel free to leave quesitons about the process on that doc so others can see them!

@efriis efriis closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants