Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partners/ollama: Enabled Token Level Streaming when Using Bind Tools for ChatOllama #27689

Merged
merged 7 commits into from
Nov 15, 2024
Merged

partners/ollama: Enabled Token Level Streaming when Using Bind Tools for ChatOllama #27689

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8f84d46
bug: chatollama now streams chunks even when tools are bound
ElhamBadri2411 Oct 28, 2024
e3396fb
chore: formatting
ElhamBadri2411 Oct 28, 2024
db2d4c4
bug: fixed integration test
ElhamBadri2411 Nov 1, 2024
4e51472
Merge branch 'master' of https://github.com/langchain-ai/langchain in…
ElhamBadri2411 Nov 4, 2024
3e0f8ca
Made _create_chat_stream modifications concise
4meyDam1e Nov 14, 2024
08b5187
Merge branch 'master' into bug/chatollam-token-level-streaming-bindto…
ccurme Nov 15, 2024
39e1d7a
update async tool calling
ccurme Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/partners/ollama/langchain_ollama/chat_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,10 +514,10 @@ def _create_chat_stream(

params["options"]["stop"] = stop
if "tools" in kwargs:
yield self._client.chat(
yield from self._client.chat(
model=params["model"],
messages=ollama_messages,
stream=False,
stream=True,
options=Options(**params["options"]),
keep_alive=params["keep_alive"],
format=params["format"],
Expand Down
Loading