Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community: BM25Retriever preservation of document id #27019

Merged
merged 5 commits into from
Dec 4, 2024
Merged

community: BM25Retriever preservation of document id #27019

merged 5 commits into from
Dec 4, 2024

Conversation

TupleType
Copy link
Contributor

@TupleType TupleType commented Oct 1, 2024 •
edited
Loading

Currently this retriever discards document ids

@vercel Vercel
Copy link

vercel bot commented Oct 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 0:35am

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. community Related to langchain-community Ɑ: retriever Related to retriever module labels Oct 1, 2024
@TupleType TupleType changed the title community: Add BM25Retriever preservation of document id community: BM25Retriever preservation of document id Oct 1, 2024
@TupleType
Copy link
Contributor Author

Hey @baskaryan could you please review?
Thank you!

efriis
efriis reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a unit test?

@efriis efriis self-assigned this Oct 8, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 9, 2024
@TupleType
Copy link
Contributor Author

could you add a unit test?

Done

@TupleType TupleType requested a review from efriis October 9, 2024 08:49
@TupleType
Copy link
Contributor Author

could you add a unit test?

Done

@efriis

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Dec 4, 2024
@efriis efriis enabled auto-merge (squash) December 4, 2024 00:22
@efriis efriis merged commit d34bf78 into langchain-ai:master Dec 4, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efriis efriis efriis approved these changes

Assignees

@efriis efriis

Labels
community Related to langchain-community lgtm PR looks good. Use to confirm that a PR is ready for merging. Ɑ: retriever Related to retriever module size:M This PR changes 30-99 lines, ignoring generated files.
Projects
PR Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TupleType @efriis