Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: refactor opensearch query constructor to use wildcard instead of match in the contain comparator #26653

Merged
merged 69 commits into from
Dec 16, 2024

Conversation

quintinoandre
Copy link
Contributor

@quintinoandre quintinoandre commented Sep 19, 2024

  • Description: Changed the comparator to use a wildcard query instead of match. This modification allows for partial text matching on analyzed fields, which improves the flexibility of the search by performing full-text searches that aren't limited to exact matches.
  • Issue: The previous implementation used a match query, which performs exact matches on analyzed fields. This approach limited the search capabilities by requiring the query terms to align with the indexed text. The modification to use a wildcard query instead addresses this limitation. The wildcard query allows for partial text matching, which means the search can return results even if only a portion of the term matches the text. This makes the search more flexible and suitable for use cases where exact matches aren't necessary or expected, enabling broader full-text searches across analyzed fields.
    In short, the problem was that match queries were too restrictive, and the change to wildcard queries enhances the ability to perform partial matches.
  • Dependencies: none
  • Twitter handle: @Andre_Q_Pereira

André Quintino and others added 30 commits June 18, 2024 00:05
…vironment variable

- Enhance JiraAPIWrapper to accept the 'cloud' parameter through an environment variable.
- This update allows more flexibility in configuring the environment for the Jira API.
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arguably a breaking change but IMO this is a bug fix given the operator is CONTAIN.

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Dec 16, 2024
@ccurme ccurme merged commit a26c786 into langchain-ai:master Dec 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants