core[fix] @tool typing #25856
Open
core[fix] @tool typing #25856
+35
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
langchain
ccurme
added
Ɑ: core
samjove
force-pushed
the
24089_fix_tool_typing
branch
from
0a52e2d to
0c6914c
Compare
baskaryan
reviewed
Sep 2, 2024
| infer_schema: bool = True, | ||
| response_format: Literal["content", "content_and_artifact"] = "content", | ||
| parse_docstring: bool = False, | ||
| error_on_invalid_docstring: bool = True, | ||
| ) -> Callable: | ||
| ) -> StructuredTool: |
There was a problem hiding this comment.
this should be Union[Tool, Callable] i believe
@tool(return_direct=True) # this outputs a Callable that creates a StructuredTool
def foo(...)
@tool(infer_schema=False) # this outputs a Callable that creates a Tool
def foo(...)
baskaryan
reviewed
Dec 19, 2024
| @@ -101,6 +101,17 @@ async def _arun(self, arg1: int, arg2: bool, arg3: Optional[dict] = None) -> str | |||
| raise NotImplementedError | |||
|
|
|||
|
|
|||
| def test_tool_typing() -> None: | |||
There was a problem hiding this comment.
could we add a test case for each tool overload variant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fixes '@tool' typing addressing incompatibility in assignment
Issue: #24089