multiple: add stop attribute
#22573
Merged
multiple: add stop attribute
#22573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
ccurme
changed the title
stop attributestop attribute
dosubot
bot
added
size:M
baskaryan
reviewed
Jun 6, 2024
| @@ -97,6 +99,8 @@ def _default_params(self) -> Mapping[str, Any]: | |||
| "top_k_return": self.top_k_return, | |||
| "n": self.n, | |||
| } | |||
| if self.stop: | |||
| base_params["stop_sequences"] = self.stop | |||
There was a problem hiding this comment.
unrelated but the check in L126 doesn't do anything, it couldn't be in kwargs
baskaryan
reviewed
Jun 6, 2024
| @@ -492,6 +492,9 @@ class Config: | |||
| max_retries: int = 2 | |||
| """Number of retries allowed for requests sent to the Anthropic Completion API.""" | |||
|
|
|||
| stop: Optional[List[str]] = Field(None, alias="stop_sequences") | |||
There was a problem hiding this comment.
can we make the attribute stop_sequences and the alias stop? since stop_sequences is the Anthropic name for it
baskaryan
reviewed
Jun 6, 2024
| @@ -35,6 +35,8 @@ class ChatAI21(BaseChatModel, AI21Base): | |||
| You can view the options at https://github.com/AI21Labs/ai21-python?tab=readme-ov-file#model-types""" | |||
| num_results: int = 1 | |||
| """The number of responses to generate for a given prompt.""" | |||
| stop: Optional[List[str]] = None | |||
There was a problem hiding this comment.
same comment about making this stop_sequences and alias stop
There was a problem hiding this comment.
missed your comments, will add in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.