partners: replace deprecated .dict() with .model_dump() in openai base.py #16629
Conversation
using pydantic's new function. it produces the same result without throwing a warning console message
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: models
|
LangChain needs to be both pydantic 1 and 2 compatible for now. Running tests expecting the tests to fail. If they don't fail we should confirm why not. |
dosubot
bot
added
size:S
|
@eyurtsev The tests do fail as you suspected. I made an additional commit to satisfy both v1 and v2 (and 3) but also avoid the deprecation warnings. Local tests do not throw any errors on my end |
|
so no merge @baskaryan? 😔 |
|
When do we expect this to be solved, it is peppering our code with lots of warnings... |
|
btw, Ideally the PR should cover all instances of this problem (for example the embeddings module has the same issue) |
|
@eyurtsev i actually think any OpenAI-returned object, whether you've got pydantic v1 or v2 installed, should support model_dump https://github.com/openai/openai-python/blob/d231d1fa783967c1d3a1db3ba1b52647fff148ac/src/openai/_models.py#L150 |
|
great observation @baskaryan. they seem to be using .dict() under the hood here but through the model_dump() function name in case of pydantic v1. |
|
Ah if OpenAI already supports it we can just upgrade. Shall we just change to model_dump version? |
|
Closed by mistake, re-opened in #17404. Sorry 😢 |
…n (reopen #16629) (#17404) --------- Co-authored-by: Bagatur <[email protected]>
…n (reopen langchain-ai#16629) (langchain-ai#17404) --------- Co-authored-by: Bagatur <[email protected]>
.model_dump()function. It produces the same result as.dict()without throwing a deprecation warning message,dictmethod is deprecated; usemodel_dumpinstead [pydantic] #15997 ,Thanks :)