Use env for revision id if not passed in as param; use git describe as backup
#16227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
the
🤖:improvement
samnoyes
changed the title
git describeas backupgit describe as backup
eyurtsev
reviewed
Jan 18, 2024
| @@ -1330,6 +1335,24 @@ def run_on_dataset( | |||
| return container.finish(batch_results, verbose=verbose) | |||
|
|
|||
|
|
|||
| def _get_default_revision_id() -> Optional[str]: | |||
There was a problem hiding this comment.
Could you add a description of what LANGCHAIN_REVISION_ID is? And which git repo is this for?
There was a problem hiding this comment.
Do we need to memoize the result if git describe --tags --dirty fails? e.g., no git installed or no .git found?
There was a problem hiding this comment.
Ya - he's implementing in the SDK also! we memoize there
dosubot
bot
added
size:XS
dosubot
bot
added
the
lgtm
dosubot
bot
added
size:S
dosubot
bot
added
size:M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.