Feat: support unstructured_kwargs for s3 loader #15473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: doc loader
baskaryan
reviewed
Jan 15, 2024
baskaryan
reviewed
Jan 29, 2024
| @@ -83,7 +84,7 @@ def __init__( | |||
| the client will be the result of calling ``merge()`` on the | |||
| default config with the config provided to this call. | |||
| """ | |||
| super().__init__() | |||
| super().__init__(**unstructured_kwargs) | |||
There was a problem hiding this comment.
could we add documentation to the docstring? otherwise looks good to me!
|
@hwchase17 I believe this minor adjustment has the potential to overcome a significant challenge we've been facing. Would it be possible for someone to review and merge this change? I'm confident it will bring substantial improvements. |
baskaryan
approved these changes
Mar 27, 2024
dosubot
bot
added
the
lgtm
dosubot
bot
added
size:S
baskaryan
approved these changes
Mar 27, 2024
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this pull request
Mar 30, 2024
…n-ai#15473) fix langchain-ai#15472 Co-authored-by: Bagatur <[email protected]>
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
fix #15472 Co-authored-by: Bagatur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #15472