-
Notifications
You must be signed in to change notification settings - Fork 15.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Drive Loader: Modify docs to always set the env var #14791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
snehil002
commented
Dec 16, 2023
•
edited by baskaryan
Loading
edited by baskaryan
- Description: Code written by following, the official documentation of Google Drive Loader, gives errors. I have opened an issue regarding this. See Google Drive Loader: The code in the Official Doc does not work; and Setting environment variable GOOGLE_APPLICATION_CREDENTIALS is important, though its value is not #14725. This is a pull request for modifying the documentation to use an approach that makes the code work. Basically, the change is that we need to always set the GOOGLE_APPLICATION_CREDENTIALS env var to an emtpy string, rather than only in case of RefreshError. Also, rewrote 2 paragraphs to make the instructions more clear.
- Issue: See this related issue # 14725
- Dependencies: NA
- Tag maintainer: @baskaryan
- Twitter handle: NA
Code written by following the official documentation of Google Drive Loader, is not working. I have opened an issue regarding this. See # 14725. This is a pull request for modifying the documentation to use an approach that makes the code work. Basically, the change is that we need to always set the GOOGLE_APPLICATION_CREDENTIALS env var to an emtpy string, rather than only in case of RefreshError. Also, rewrote 2 paragraphs to make the instructions more clear.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:XS
This PR changes 0-9 lines, ignoring generated files.
Ɑ: doc loader
Related to document loader module (not documentation)
🤖:docs
Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder
labels
Dec 16, 2023
snehil002
changed the title
Modify doc to always set env var
Google Drive Loader: Modify docs to always set the env var
Dec 17, 2023
Undertone0809
approved these changes
Dec 17, 2023
Hello @Undertone0809 , @baskaryan , |
Hello @hwchase17, |
baskaryan
approved these changes
Mar 29, 2024
dosubot
bot
added
the
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
label
Mar 29, 2024
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this pull request
Mar 30, 2024
- **Description:** Code written by following, the official documentation of [Google Drive Loader](https://python.langchain.com/docs/integrations/document_loaders/google_drive), gives errors. I have opened an issue regarding this. See langchain-ai#14725. This is a pull request for modifying the documentation to use an approach that makes the code work. Basically, the change is that we need to always set the GOOGLE_APPLICATION_CREDENTIALS env var to an emtpy string, rather than only in case of RefreshError. Also, rewrote 2 paragraphs to make the instructions more clear. - **Issue:** See this related [issue # 14725](langchain-ai#14725) - **Dependencies:** NA - **Tag maintainer:** @baskaryan - **Twitter handle:** NA Co-authored-by: Snehil <[email protected]> Co-authored-by: Bagatur <[email protected]>
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
- **Description:** Code written by following, the official documentation of [Google Drive Loader](https://python.langchain.com/docs/integrations/document_loaders/google_drive), gives errors. I have opened an issue regarding this. See #14725. This is a pull request for modifying the documentation to use an approach that makes the code work. Basically, the change is that we need to always set the GOOGLE_APPLICATION_CREDENTIALS env var to an emtpy string, rather than only in case of RefreshError. Also, rewrote 2 paragraphs to make the instructions more clear. - **Issue:** See this related [issue # 14725](#14725) - **Dependencies:** NA - **Tag maintainer:** @baskaryan - **Twitter handle:** NA Co-authored-by: Snehil <[email protected]> Co-authored-by: Bagatur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Ɑ: doc loader
Related to document loader module (not documentation)
🤖:docs
Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
size:XS
This PR changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.